Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for es_match() to DataFrame and Series #301

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add support for es_match() to DataFrame and Series #301

merged 1 commit into from
Oct 29, 2020

Conversation

sethmlarson
Copy link
Contributor

Closes #282

V1NAY8
V1NAY8 suggested changes Oct 28, 2020
View reviewed changes
eland/series.py Outdated Show resolved Hide resolved
@V1NAY8
Copy link
Contributor

V1NAY8 commented Oct 28, 2020 •
edited
Loading

I tried adding commits, but somehow 403 error popped up 🤔 . I might not have access

@sethmlarson
Copy link
Contributor Author

@V1NAY8 Yeah I think only users with write privileges can push to other's branches.

@V1NAY8
Copy link
Contributor

V1NAY8 commented Oct 29, 2020

Ah! I get it, I usually do check the Allow edits and access to secrets by maintainers checkbox. So, you could push commit on top of my PR 😁

@sethmlarson sethmlarson merged commit cb4cd08 into elastic:master Oct 29, 2020
@sethmlarson sethmlarson deleted the es-match branch October 29, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V1NAY8 V1NAY8 V1NAY8 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Elasticsearch full-text queries
2 participants
@sethmlarson @V1NAY8