Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event] Clean up Event fields #2226

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Event] Clean up Event fields #2226

merged 1 commit into from
Jun 28, 2023

Conversation

nicpenning
Copy link
Contributor

New PR to properly generate docs by better following the contributing guide.

Added "is" to clear up a sentence and made more fields stick out using the ` characters which makes it more consistent with the rest of the documentation.

Cancels #2220

@nicpenning nicpenning requested a review from a team as a code owner June 28, 2023 19:39
@github-actions
Copy link

Documentation changes preview: https://ecs_2226.docs-preview.app.elstc.co/diff

@ebeahan
Copy link
Member

ebeahan commented Jun 28, 2023

@elasticmachine run elasticsearch-ci/docs

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ebeahan ebeahan merged commit 2abd912 into elastic:main Jun 28, 2023
2 checks passed
@nicpenning nicpenning deleted the clean_event_fields branch June 28, 2023 20:37
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jun 28, 2023
(cherry picked from commit 2abd912)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan
Copy link
Member

ebeahan commented Jun 28, 2023

💚 All backports created successfully

Status Branch Result
8.9
8.8

Questions ?

Please refer to the Backport tool documentation

ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jun 28, 2023
(cherry picked from commit 2abd912)

# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Jun 28, 2023
(cherry picked from commit 2abd912)

Co-authored-by: Nic <nicpenning@gmail.com>
ebeahan added a commit that referenced this pull request Jun 28, 2023
(cherry picked from commit 2abd912)

Co-authored-by: Nic <nicpenning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants