Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES artifacts folder restructuring #1700

Merged
merged 10 commits into from
Dec 22, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Dec 20, 2021

In the spirit of #1587 , this PR updates the structure of the generated ES artifacts. Now, instead of a version folder and a component folder, we will have a legacy and a composable folder (which will now contain the template and the component folder).

See here to explore the new structure in my branch.

@kgeller kgeller self-assigned this Dec 20, 2021
@kgeller kgeller changed the title Generated artifacts restructure ES artifacts folder restructuring Dec 20, 2021
@kgeller kgeller marked this pull request as ready for review December 20, 2021 20:38
@kgeller kgeller requested a review from a team December 20, 2021 20:38
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

generated/elasticsearch/composable/component/email.json Outdated Show resolved Hide resolved
@ebeahan
Copy link
Member

ebeahan commented Dec 21, 2021

Do we need to sync with @yaauie before implementing this change in the 8.0 branch?

@kgeller kgeller merged commit da91eb6 into elastic:main Dec 22, 2021
@kgeller kgeller deleted the generated-artifacts-restructure branch December 22, 2021 15:21
kgeller added a commit to kgeller/ecs that referenced this pull request Dec 22, 2021
# Conflicts:
#	experimental/generated/elasticsearch/composable/component/cgroup.json
#	generated/elasticsearch/composable/component/email.json
kgeller added a commit to kgeller/ecs that referenced this pull request Dec 22, 2021
# Conflicts:
#	experimental/generated/elasticsearch/composable/component/cgroup.json
#	generated/elasticsearch/composable/component/email.json
kgeller added a commit to kgeller/ecs that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants