Pe ordering fix #1605
Merged
Pe ordering fix #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
requested changes
Sep 9, 2021
| @@ -14448,6 +14624,13 @@ threat: | |||
| - threat.indicator.x509 | |||
| prefix: threat. | |||
| reused_here: | |||
| - full: threat.indicator.pe | |||
There was a problem hiding this comment.
I think we want these gone, right? pe will be nested under file or process, but not as a sibling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in #1603, we realized we were missing
pe.*under threat.indicator.file and `threat.enrichments.indicator.file' like the threat RFC describes. I realized this was due to an ordering issue on our field reuses. We solve this issue the same way here for 'group' at 'user'.Sibling PR to remove the incorrect nestings #1606