Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining golang dependencies #1585

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Remove remaining golang dependencies #1585

merged 6 commits into from
Aug 23, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Aug 20, 2021

This PR removes the remaining golang dependencies in the project Makefile.

check-license-header

Remove check-license-header rule from Makefile since check-license-header only works with .go source files.

misspell

  • Install the misspell binary instead of go get
  • Add -error flag to throw a non-zero exit code for CI
  • Include docs/* and experimental/schema/* directives in the misspell check.

GitHub workflow

Remove the setup-go step since golang is no longer a required dependency for testing.

Closes #630

@ebeahan ebeahan added the 8.0.0 label Aug 20, 2021
@ebeahan ebeahan self-assigned this Aug 20, 2021
@ebeahan ebeahan requested a review from kgeller August 20, 2021 18:06
@ebeahan ebeahan mentioned this pull request Aug 20, 2021
Closed
4 tasks
kgeller
kgeller approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Appreciate the misspell check :)

@ebeahan ebeahan merged commit 9b61086 into elastic:master Aug 23, 2021
@ebeahan ebeahan deleted the remove-golang-dep-for-misspell branch August 23, 2021 16:19
@djptek djptek mentioned this pull request Oct 20, 2021
Closed
@ebeahan ebeahan mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@ebeahan ebeahan

Labels
8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Golang dependencies
2 participants
@ebeahan @kgeller