Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Bulleted list of expected nesting locations #1473

Merged
merged 6 commits into from
Jun 28, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 24, 2021

Summary

Change the flat, comma-separated list of expected field reuse locations into a bulleted list. As the number of included reuses has grown for some field sets, I think the bulleted list is easier to consume.

Current

Screen Shot 2021-06-24 at 2 45 02 PM

Proposed Change

Screen Shot 2021-06-24 at 2 45 25 PM

Docs preview

@ebeahan ebeahan self-assigned this Jun 24, 2021
@ebeahan ebeahan requested a review from a team June 24, 2021 19:58
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot clearer, LGTM!

@ebeahan ebeahan merged commit 11aab1d into elastic:master Jun 28, 2021
@ebeahan ebeahan deleted the docs/enumerate-field-reuses branch June 28, 2021 17:17
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 28, 2021
* enumerated bullet list

* apply field reuse changes

* add changelog

* dangling period

* make it happen
# Conflicts:
#	docs/field-details.asciidoc
ebeahan added a commit that referenced this pull request Jun 28, 2021
* enumerated bullet list

* apply field reuse changes

* add changelog

* dangling period

* make it happen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants