Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove guidance to lowercase http.request.method. #1443

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Remove guidance to lowercase http.request.method. #1443

merged 4 commits into from
Jun 2, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented May 28, 2021 •
edited
Loading

In addition to removing the deprecation note, I included new guidance about retaining the casing from the original event.

I also limited the Example attribute to a single value since this field is not expected to be an array.

Closes #1363

@ebeahan ebeahan self-assigned this May 28, 2021
@ebeahan ebeahan added the 8.0.0 label May 28, 2021
@ebeahan ebeahan requested a review from a team May 28, 2021 22:11
djptek
djptek approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit f6d659c into elastic:master Jun 2, 2021
@ebeahan ebeahan deleted the remove/http.request.method-lowercase-guidance branch June 2, 2021 17:38
@epixa epixa added the breaking label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djptek djptek djptek approved these changes

Assignees

@ebeahan ebeahan

Labels
8.0.0 breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove guidance to lowercase http.request.method
3 participants
@ebeahan @djptek @epixa