Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct data type for group.ref and software.ref experimental fields #1351

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Apr 12, 2021

This PR fixes an incorrect type setting introduced into the experimental schema in #1344

type: url is invalid and has been replaced with type: keyword.

@ebeahan
Copy link
Member Author

ebeahan commented Apr 12, 2021

Test failures expected until #1254 is merged.

@ebeahan ebeahan force-pushed the rfc/0018/fix-stage-1-exp-changes branch from c5d0eb5 to 9611a00 Compare April 13, 2021 14:37
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebeahan ebeahan merged commit 2d69d7f into elastic:master Apr 13, 2021
@ebeahan ebeahan deleted the rfc/0018/fix-stage-1-exp-changes branch April 13, 2021 19:53
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 13, 2021
…lds (elastic#1351)

# Conflicts:
#	experimental/generated/csv/fields.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants