Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating descriptions to Elastic Security #1305

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Updating descriptions to Elastic Security #1305

merged 3 commits into from
Mar 18, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Mar 17, 2021 •
edited
Loading

To better align with the security solution product naming, these are some description updates to Elastic Security from Elastic SIEM.

@kgeller kgeller linked an issue Mar 17, 2021 that may be closed by this pull request
Update descriptions to use "Elastic Security" #1284
Closed
ebeahan
ebeahan reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one comment around the go dependencies, but overall this looks great! Nice work! 😄

scripts/go.sum Outdated Show resolved Hide resolved
ebeahan
ebeahan approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I added a couple of labels to facilitate backporting. I'll sync with you about it out-of-band.

@ebeahan ebeahan merged commit 192356c into elastic:master Mar 18, 2021
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Mar 18, 2021
@kgeller @ebeahan
Updating descriptions to Elastic Security (elastic#1305)
51c69fa 
* updating descriptions to better align with security product

* changelog entry

* reverting go versioning change
@ebeahan ebeahan mentioned this pull request Mar 18, 2021
Merged
ebeahan added a commit that referenced this pull request Mar 18, 2021
@ebeahan @kgeller
Updating descriptions to Elastic Security (#1305) (#1308)
50d37ef 
Co-authored-by: Kylie Geller <kylie.geller@gmail.com>
@ebeahan ebeahan added the 1.10.0 label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

Assignees
No one assigned
Labels
1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update descriptions to use "Elastic Security"
2 participants
@kgeller @ebeahan