-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to generate ECS fields as dynamic index template #1600
Comments
Hi @ypid-geberit ! The ECS team has discussed recently how we want to consolidate down the artifacts that we create / maintain for users and have created a meta issue to start the discussion there. I think that, combined with the notion that dynamic mappings are more intended for experimentation and exploration (see docs), we will probably stick with explicit mappings for the time being. Please share any/all thoughts you have on the future of our generated templates on that meta issue. We haven't made any decisions yet and would love input from the community! |
@kgeller This is a new feature/idea. I would prefer to keep this separate as the discussion could get long. It is not yet supported.
To be precise about my idea. I intend to generate a very tight set of dynamic mapping rules that are basically equivalent of the current explicit mapping. Is there a better way to address the points I identified as advantages of dynamic templates in #1600 (comment)? |
@ypid-geberit we can continue here! I will check with the wider ECS team to make sure I am not missing anything. In the meantime, I will re-open this, and also link you to another user's dynamic template generator in case it's of any use https://github.com/mbudge/dynamic-template-generator. |
Thanks so much for linking to https://github.com/mbudge/dynamic-template-generator, I would probably never have found that! Looks like a good starting point for trying this. Also thanks for reopening and checking. |
@ypid-geberit while I can appreciate the potential flexibility that adding dynamic fields could add in the right use cases, there is one showstopper to incorporating these into ECS, which is the potential for performance issues in the wrong use cases. Those performance issues could be critical for our users. Additionally, a generic format can never be 100% optimal, so we use benchmarking to validate that ECS performs comparably (or better) as the Elastic Stack and ECS Format evolve. We would no longer be able to benchmark if the mappings were to leverage dynamic fields. I would recommend that dynamic fields be implemented as custom fields, alongside, but not within ECS I think this has been a truly valuable discussion and thank you for your input, it will be really useful for anyone who has the same question to find it here in the future, thanks @ypid-geberit ! |
Summary
The ECS tools currently generate ES index templates which use explicit mapping to express the ECS fields. I would like to discuss if dynamic templates could make sense in some cases.
Motivation:
Dynamic templates pro:
Explicit mapping pro:
Detailed Design:
I can implement a POC after some feedback that show me that I have not overlooked something why dynamic templates are a no-no. For background, I have used dynamic templates for years for our logging use case without issues.
The text was updated successfully, but these errors were encountered: