Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to calls that create SearchDeploymentsParams #482

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

orestisfl
Copy link
Contributor

@orestisfl orestisfl commented Aug 29, 2024

Something I saw missing from our usage of the cloud-sdk.

Description

Adds a proper context object to API functions that create SearchDeploymentsParams structs.

Motivation and Context

Adding a context to http calls is considered best practice in Go.

How Has This Been Tested?

I haven't tested this but I don't think more coverage is needed as the default case (no context) will behave the same and if a context is provided, it will be passed to the http client.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Something I saw missing from our usage of the cloud-sdk.
@orestisfl orestisfl requested a review from a team as a code owner August 29, 2024 15:39
Copy link
Member

@gigerdo gigerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gigerdo gigerdo merged commit ebe4456 into elastic:master Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants