Ingress support for Elasticsearch and Kibana Helm Charts #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
added
discuss
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Remove ARN from example. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
deploy/eck-stack/charts/eck-elasticsearch/templates/ingress.yaml
Outdated
Show resolved
Hide resolved
Fix example. Add tests for es/kb ingress. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
approved these changes
Jul 19, 2024
deploy/eck-stack/charts/eck-elasticsearch/templates/ingress.yaml
Outdated
Show resolved
Hide resolved
| my: label | ||
| pathType: Prefix | ||
| hosts: | ||
| - host: "*.company.dev" |
There was a problem hiding this comment.
Why are you suggesting to use a wildcard here?
There was a problem hiding this comment.
No suggestion, it's part of what I tested. I'll update to be a non-wildcard now.
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
kvalliyurnatt
approved these changes
Jul 19, 2024
barkbay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Helm Ingress support to both ECK-Elasticsearch and ECK-Kibana Helm Charts. There's still an open question here, but after some internal discussions we feel that the simplified version here is a good starting point. If there's demand for the ability to add additional hosts/tls sections to ES/KB ingress, then we can add that support in a future relase. Removing draft status to enable review.
TODO:
/docs.