Handle Serverless version in association versions check #7896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite test this -f p=gke,s=8.14.0 -m t=TestVersionUpgradeOrdering* |
pebrc
reviewed
Jun 13, 2024
| } | ||
|
|
||
| func (kibanaVersionResponse) IsServerless() bool { | ||
| return false |
There was a problem hiding this comment.
I think we could look at build flavour here as well:
{
"name": "kb",
"uuid": "8e06f008-43d4-4b38-ae49-51256b8945da",
"version": {
"number": "8.15.0",
"build_hash": "cf768dcb71f422fbf3bc7cc16f3e3d3513ceac6a",
"build_number": 75272,
"build_snapshot": false,
"build_flavor": "serverless",
"build_date": "2024-06-12T16:25:20.017Z"
}
}| @@ -78,7 +78,7 @@ type AssociationInfo struct { //nolint:revive | |||
| AssociationConfAnnotationNameBase string | |||
| // ReferencedResourceVersion returns the currently running version of the referenced resource. | |||
| // It may return an empty string if the version is unknown. | |||
| ReferencedResourceVersion func(c k8s.Client, association commonv1.Association) (string, error) | |||
| ReferencedResourceVersion func(c k8s.Client, association commonv1.Association) (string, bool, error) | |||
There was a problem hiding this comment.
Document the boolean return value?
pebrc
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to detect when a referenced resource is an Elasticsearch project, and skip version check if it's the case.