Use hash for secure settings secret updates #7843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating secure settings secrets
|
buildkite test this p=gke,s=8.13.2 -m t=TestUpdateESSecureSettings,t=TestUpdateKibanaSecureSettings |
|
@thbkrkr I understand the reasoning behind this, but is this going to cause a rolling-restart for all customers who upgrade to this version? It seems as though it will. |
pebrc
approved these changes
May 24, 2024
|
Yes, upgrading to the eck version including this new change will result in an unavoidable graceful restart. For users experiencing this problem, this should be the last one without real data change :) |
|
I created #7846 to not forget to update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the hash of the
-es-secure-settingsSecret data instead of its resource version to know if Pods need to be recreated to update the Keystore.This will avoid unnecessary restarts of Elasticsearch restarts if the Secret resource version changes without changing the data.
Note: upgrading to the eck version including this new change will result in a graceful restart.
Resolves #7842.