chore(deps): update docker.io/library/golang docker tag to v1.22.1

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
docker.io/library/golang	final	patch	1.22.0 -> 1.22.1
docker.io/library/golang	stage	patch	1.22.0 -> 1.22.1

---

Configuration

📅 Schedule: Branch creation - "after 1am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[barkbay]

revive linter is not happy, generating a bazillion of

foo.go:25:14: unused-parameter: parameter 'bar' seems to be unused, consider removing or renaming it as _ (revive)

Autofix does not work. I also tried to disable it using:

linters-settings:
  revive:
    rules:
      - name: unused-parameter
        disabled: true

But this seems to have the side effect of also disabling other rules like var-naming:

diff --git a/hack/deployer/runner/settings.go b/hack/deployer/runner/settings.go
index ceee8eefe..5de3bda9d 100644
--- a/hack/deployer/runner/settings.go
+++ b/hack/deployer/runner/settings.go
@@ -17,7 +17,7 @@ type Plans struct {
 
 // Plan encapsulates information needed to provision a cluster
 type Plan struct {
-       Id                string `yaml:"id"` //nolint:revive
+       Id                string `yaml:"id"` 
        Operation         string `yaml:"operation"`
        ClusterName       string `yaml:"clusterName"`
        ClientVersion     string `yaml:"clientVersion"`
@@ -96,7 +96,7 @@ type TanzuSettings struct {

I'm a bit confused about why disabling unused-parameter would have an effect on var-naming

[barkbay]

We also have a panic when generating the API documentation:

2024-03-18T08:50:10.988Z	INFO	crd-ref-docs	Processing source directory	{"directory": "/buildkite/builds/bk-agent-prod-k8s-1710751674896125133/elastic/cloud-on-k8s-operator/hack/api-docs/../../pkg/apis", "depth": 6}
--
  | panic: runtime error: invalid memory address or nil pointer dereference [recovered]
  | panic: runtime error: invalid memory address or nil pointer dereference
  | [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x61586f]
  |  
  | goroutine 72 [running]:
  | go/types.(*Checker).handleBailout(0xc00035c400, 0xc002155d40)
  | /usr/local/go/src/go/types/check.go:367 +0x88
  | panic({0xa77900?, 0x1041c00?})
  | /usr/local/go/src/runtime/panic.go:770 +0x132
  | go/types.(*StdSizes).Sizeof(0x0, {0xc221e8, 0x1049c00})
  | /usr/local/go/src/go/types/sizes.go:228 +0x30f
  | go/types.(*Config).sizeof(...)
  | /usr/local/go/src/go/types/sizes.go:333
  | go/types.representableConst.func1({0xc221e8?, 0x1049c00?})
  | /usr/local/go/src/go/types/const.go:76 +0x9e
  | go/types.representableConst({0xc27130, 0x1017a60}, 0xc00035c400, 0x1049c00, 0xc0021554b0)
  | /usr/local/go/src/go/types/const.go:92 +0x192
  | go/types.(*Checker).representation(0xc00035c400, 0xc0016e34c0, 0x1049c00)
  | /usr/local/go/src/go/types/const.go:256 +0x65
  | go/types.(*Checker).implicitTypeAndValue(0xc00035c400, 0xc0016e34c0, {0xc222b0, 0xc0001e0cb0})
  | /usr/local/go/src/go/types/expr.go:375 +0x2d7
  | go/types.(*Checker).assignment(0xc00035c400, 0xc0016e34c0, {0xc222b0, 0xc0001e0cb0}, {0xb246b4, 0x14})
  | /usr/local/go/src/go/types/assignments.go:52 +0x2e5
  | go/types.(*Checker).initConst(0xc00035c400, 0xc0023b2cc0, 0xc0016e34c0)
  | /usr/local/go/src/go/types/assignments.go:126 +0x2c5
  | go/types.(*Checker).constDecl(0xc00035c400, 0xc0023b2cc0, {0xc244d8, 0xc001632160}, {0xc244d8, 0xc001632180}, 0x0)
  | /usr/local/go/src/go/types/decl.go:490 +0x311
  | go/types.(*Checker).objDecl(0xc00035c400, {0xc2c340, 0xc0023b2cc0}, 0x0)
  | /usr/local/go/src/go/types/decl.go:191 +0xa49
  | go/types.(*Checker).packageObjects(0xc00035c400)
  | /usr/local/go/src/go/types/resolver.go:693 +0x4dd
  | go/types.(*Checker).checkFiles(0xc00035c400, {0xc000596a50, 0x5, 0x5})
  | /usr/local/go/src/go/types/check.go:408 +0x1a5
  | go/types.(*Checker).Files(...)
  | /usr/local/go/src/go/types/check.go:372
  | sigs.k8s.io/controller-tools/pkg/loader.(*loader).typeCheck(0xc0002642a0, 0xc0007180e0)
  | /go/pkg/mod/sigs.k8s.io/controller-tools@v0.2.2/pkg/loader/loader.go:284 +0x35b
  | sigs.k8s.io/controller-tools/pkg/loader.(*Package).NeedTypesInfo(0xc0007180e0)
  | /go/pkg/mod/sigs.k8s.io/controller-tools@v0.2.2/pkg/loader/loader.go:96 +0x39
  | sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check(0xc00120d9b0, 0xc0007180e0)
  | /go/pkg/mod/sigs.k8s.io/controller-tools@v0.2.2/pkg/loader/refs.go:249 +0x277
  | sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check.func1(0x47?)
  | /go/pkg/mod/sigs.k8s.io/controller-tools@v0.2.2/pkg/loader/refs.go:243 +0x53
  | created by sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check in goroutine 12
  | /go/pkg/mod/sigs.k8s.io/controller-tools@v0.2.2/pkg/loader/refs.go:241 +0x18c
  | Removing /tmp/crd-ref-docs-CqXWK
  | make: *** [Makefile:133: generate-api-docs] Error 2

[thbkrkr]

revive linter is not happy, generating a bazillion of

Just to explain where this comes from, the new bk agent image updates golangci-lint from 1.55.2 to 1.56.2 and in 1.56.1, revive was updated from 1.3.6 to 1.3.7, bringing:

• Check function literals in unused-param mgechev/revive#966