Add Health to Logstash Status #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a Health column to the LogstashStatus, displaying * Green if all pods are ready, and all associations are configured and established * Yellow if not all pods are ready, but all associations are configured and established * Red if neither of those are true
kaisecheng
reviewed
Feb 2, 2024
There was a problem hiding this comment.
CI red because of the missing docs from make generate.
I have tried to run with
cd hack/upgrade-test-harness && go run main.go --from-release=v2110 --to-release=upcoming --log-level=debug
but logstash health is still missing
2024-02-02T12:39:06.611Z DEBUG eck-upgrade.fixture Pod ls-ls-0 is running 8.12.0 {"step": "TestStatusOfResources[v2110]", "step": "CheckLogstash[v2110]"}
2024-02-02T12:39:06.611Z DEBUG eck-upgrade.fixture Status mismatch: want={health:green nodes:1 version:8.12.0} have={health: nodes:1 version:8.12.0} {"step": "TestStatusOfResources[v2110]", "step": "CheckLogstash[v2110]"}
Edit: The change is good and gives Health: green. Test failed because the command test against the old version of operator. LGTM
|
My steps to run the test
|
pebrc
approved these changes
Feb 5, 2024
|
Thank you @pebrc! I don't have merge access to this repo, so would you mind hitting the merge button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Health column to the LogstashStatus, displaying
This closes #7527