Validating policy ID only when running in Fleet mode for Elastic Agent #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
reviewed
Jun 21, 2023
| @@ -38,7 +38,7 @@ func (a *Agent) GetWarnings() []string { | |||
| if a == nil { | |||
| return nil | |||
| } | |||
| if len(a.Spec.PolicyID) == 0 { | |||
| if a.Spec.Mode == AgentFleetMode && len(a.Spec.PolicyID) == 0 { | |||
There was a problem hiding this comment.
I think this change makes perfect sense, but I also think it's a perfect opportunity for a set of unit tests around this function.
There was a problem hiding this comment.
There are existing unit tests, will fix those and add a new one
There was a problem hiding this comment.
I was only looking for a webhooks_test.go file and didn't see it. My apologies.
pebrc
changed the title
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Agent webhook attempts to check if PolicyID is set whether or not the Agent is running in fleet or standalone mode, This check should only be done in fleet mode. Fixes #6903