Add missing maps webhook, fix inconsistencies #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
changed the title
thbkrkr
reviewed
Mar 6, 2023
There was a problem hiding this comment.
Looks like the static manifest is generated by controller-gen I am not sure why we need that.
I'm not sure either, maybe to keep the reference version and be able to compare with our template. We started managing the definition of webhooks in templates almost from the start (#2126).
If we follow this logic, we should also update the kubebuilder:webhook marker here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6151
Fixes #6152
I also removedLooks like the static manifest is generated by controller-gen I am not sure why we need that.config/webhook/manifests.yamlI am not sure what purpose it still served. It seems to me that it is unused.