Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum version to use Elasticsearch file-based settings feature #6305

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Update minimum version to use Elasticsearch file-based settings feature #6305

merged 2 commits into from
Jan 11, 2023
+8 −7

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jan 11, 2023

This commit changes the minimum version to use the ES file-based settings feature and so the Elastic Stack configuration policies feature due to a bug in ES 8.6.0.

Relates to #6303.

@thbkrkr thbkrkr added >bug Something isn't working v2.6.1 labels Jan 11, 2023
barkbay
barkbay approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 11, 2023 •
edited
Loading

I don't understand failures in CI, e2e-tests seem to pass but the pod job ends in a failed state.

Edit: I missed an import with my new IDE not well configured with go tags to compile the e2e-tests code.

@barkbay
Copy link
Contributor

barkbay commented Jan 11, 2023 

"error":"invalid character '#' looking for beginning of value","error.stack_trace":"github.com/elastic/cloud-on-k8s/v2/test/e2e/cmd/run.(*Job).onPodEvent.func1\n\t/go/src/github.com/elastic/cloud-on-k8s/test/e2e/cmd/run/job.go:95"}

⬆️ looks like some non-json being sent to stdout

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Jan 11, 2023 

command failed: [kubectl apply -f /tmp/eck-e2e/e2e-kixc4/monitoring.yaml2326907604]: exit status 1
  stderr: error: unable to recognize "/tmp/eck-e2e/e2e-kixc4/monitoring.yaml2326907604":
    no matches for kind "Agent" in version "agent.k8s.elastic.co/v1alpha1"

Jenkins test this please

@thbkrkr thbkrkr merged commit d388114 into elastic:main Jan 11, 2023
thbkrkr added a commit to thbkrkr/cloud-on-k8s that referenced this pull request Jan 11, 2023
@thbkrkr
Update min version to use es file-based settings feature (elastic#6305)
d9d2465 
This commit changes the minimum version to use the ES file-based settings feature and so the Elastic Stack configuration policies feature due to a bug in ES 8.6.0.
@thbkrkr thbkrkr mentioned this pull request Jan 11, 2023
Merged
thbkrkr added a commit that referenced this pull request Jan 11, 2023
@thbkrkr
Update min version to use es file-based settings feature (#6305) (#6311)
458671a 
This commit changes the minimum version to use the ES file-based settings feature and so the Elastic Stack configuration policies feature due to a bug in ES 8.6.0.
@thbkrkr thbkrkr changed the title Update min version to use es file-based settings feature Update minimum version to use Elasticsearch file-based settings feature Jan 11, 2023
@thbkrkr thbkrkr deleted the update-min-version-for-es-file-settings branch January 27, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebrc pebrc pebrc approved these changes

@barkbay barkbay barkbay approved these changes

Assignees
No one assigned
Labels
>bug Something isn't working v2.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbkrkr @barkbay @pebrc