Fix helm chart rendering issues associated with indentation #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional tests to ensure rendering of custom values. Increment version of Charts
Ignore eck-stack lockfile, as it depends on un-released versions.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
…6004) * Fix Elasticsearch and Kibana ECK Helm charts rendering of custom values. Add additional tests to ensure rendering of custom values. Increment version of Charts * Upgrade eck-stack dependencies. Ignore eck-stack lockfile, as it depends on un-released versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes #5998
Issues were found with the rendering of annotations/labels, and other specific Elasticsearch values. This PR fixes all of the issues, and adds tests around the previously untested custom annotations, and labels values, and adds additional tests for custom Elasticsearch values.
Notable change
This stops version control of the
eck-stack/Chart.lockfile, as it requires an unreleased version of the child charts, so it will not be able to be rendered accurately during child chart version upgrades.