Log correlation for operator APM traces #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
reviewed
Aug 2, 2022
| @@ -107,7 +107,7 @@ func buildOutputConfig(params Params) (*settings.CanonicalConfig, error) { | |||
| return settings.NewCanonicalConfig(), nil | |||
| } | |||
|
|
|||
| credentials, err := association.ElasticsearchAuthSettings(params.Client, assoc) | |||
| credentials, err := association.ElasticsearchAuthSettings(params.Context, params.Client, assoc) | |||
There was a problem hiding this comment.
Not exactly related to this PR, but why are we storing context?
https://pkg.go.dev/context#pkg-overview
Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. The Context should be the first parameter, typically named ctx:
There was a problem hiding this comment.
I guess because the struct here is just a parameter object but I agree it is maybe not ideal.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Add log correlation to APM tracing. This replaces global log variables with loggers retrieved from a context object which carries the necessary transaction and span information for correlation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add log correlation to APM tracing. This replaces global log variables with loggers retrieved from a context object which carries the necessary transaction and span information for correlation.