Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added priority class and leader election to operator Helm chart #5538

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Added priority class and leader election to operator Helm chart #5538

merged 3 commits into from
Apr 14, 2022

Conversation

LP0101
Copy link
Contributor

@LP0101 LP0101 commented Mar 29, 2022

Added values for priorityClassName and enable-leader-election to the helm chart.

.Values.config.enableLeaderElection defaults to true
.Values.priorityClassName defaults to ""

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

3 similar comments
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the triage label Mar 29, 2022
@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality v2.2.0 labels Mar 31, 2022
@botelastic botelastic bot removed the triage label Mar 31, 2022
thbkrkr
thbkrkr reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing.

deploy/eck-operator/values.yaml Show resolved Hide resolved
deploy/eck-operator/templates/validate-chart.yaml Outdated Show resolved Hide resolved
@LP0101 @thbkrkr
Add doc for prorityClassName. Add missing newline.
9460c0c 
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@thbkrkr
Copy link
Contributor

thbkrkr commented Mar 31, 2022

Jenkins test this please

@thbkrkr thbkrkr removed the v2.2.0 label Apr 6, 2022
@LP0101
Copy link
Contributor Author

LP0101 commented Apr 8, 2022

Any update on this?

@barkbay barkbay self-assigned this Apr 14, 2022
barkbay
barkbay approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barkbay
Copy link
Contributor

barkbay commented Apr 14, 2022

Jenkins test this please

@barkbay barkbay merged commit 5cb1222 into elastic:main Apr 14, 2022
@thbkrkr thbkrkr added the v2.3.0 label Apr 21, 2022
@barkbay barkbay changed the title Added priority class and leader election to operator helm chart Added priority class and leader election to operator Helm chart Jun 17, 2022
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
@LP0101 @thbkrkr
@barkbay @fantapsody
Added priority class and leader election to operator helm chart (elas…
05f2076 
…tic#5538)

* Added priority class and leader election
* Add doc for prorityClassName. Add missing newline.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Michael Morello <michael.morello@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr left review comments

@barkbay barkbay barkbay approved these changes

Assignees

@barkbay barkbay

Labels
>enhancement Enhancement of existing functionality v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LP0101 @elasticmachine @thbkrkr @barkbay