Avoid unnecessary DELETE for non-existent secrets #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
reviewed
Mar 16, 2022
thbkrkr
reviewed
Mar 16, 2022
thbkrkr
added
>bug
thbkrkr
changed the title
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
This change guards DELETE calls on secrets (cluster license, secure settings, legacy transport certs) with a GET call through a new shared utility function to remove unnecessary load on the API server. It also renames keystore.NewResources to keystore.ReconcileResources. The reason for this rename was that while I was tracking down these DELETES, I was confused and surprised to find reconciliation activity happening in a function that appeared to be a simple constructor with New* in the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5450
This PR guards DELETE calls on secrets (cluster license, secure settings, legacy transport certs) with a GET call through a new shared utility function to remove unnecessary load on the API server.
It also renames
keystore.NewResourcestokeystore.ReconcileResources, which I am happy to back out into a separate PR if that's people are uncomfortable. The reason for this rename was that while I was tracking down these DELETES, I was confused and surprised to find reconciliation activity happening in a function that appeared to be a simple constructor withNew*in the name.