Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic Agent: Set status.ObservedGeneration from metadata.Generation #5383

Merged
merged 35 commits into from
Apr 5, 2022
Merged

Elastic Agent: Set status.ObservedGeneration from metadata.Generation #5383

merged 35 commits into from
Apr 5, 2022

Commits on Feb 22, 2022

  1. Add agent observed generation. 

    Add tests for agent observedGeneration.
modify agent reconcile behavior to ensure status updates for certain situations.
adjust common comparison to allow additional options
Update some documentation.
Make disabling of k8s client's errors simpler.
Make the status update more readable.
Configure initial state for Elastic Agent properly from current state.
Add missing comments for some exported data.
Make errors consistent with capitalization, and namespace+name.
Rename e2e test name to be more descriptive.
Update pod labels in e2e test to properly trigger generation update.
Remove failing client tests.
used keyed structs in tests.
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    fd34d3d View commit details
    Browse the repository at this point in the history

  2. Run generation and update yaml for observedGeneration description cha… 

    …nge.
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5bc9db5 View commit details
    Browse the repository at this point in the history

  3. Properly order imports

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    8b7e14a View commit details
    Browse the repository at this point in the history

  4. capitalize Agent

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    9de32ab View commit details
    Browse the repository at this point in the history

  5. remove erroneous debugging line

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    f77b470 View commit details
    Browse the repository at this point in the history

  6. renamed agent e2e test file. 

    removed erroneous cmp.AllowUnexperted()
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    30f6c8f View commit details
    Browse the repository at this point in the history

  7. Ignore generation when checking if agent status is updated during k8s… 

    … test steps.

remove WithDefaultESValidation from agent generation e2e test.
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    c6661bb View commit details
    Browse the repository at this point in the history

  8. remove unneeded nil in return from rebase.

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    58ed712 View commit details
    Browse the repository at this point in the history

  9. Add missing header to e2e test.

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b6045d0 View commit details
    Browse the repository at this point in the history

  10. Remove unused args struct

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1374e88 View commit details
    Browse the repository at this point in the history

  11. move imports around properly

    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5e03689 View commit details
    Browse the repository at this point in the history

  12. Defer agent validation to reduce repetitive code. 

    Remove unneeded struct in tests.
Move Generation e2e tests to it's own package, and use it in all Agent mutation tests.
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b96cd85 View commit details
    Browse the repository at this point in the history

  13. Updating metav1.Object -> client.Object, and using type switch to get… 

    … observedGeneration.
    @naemono
    naemono committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2bc4fd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Allow status to be updated even if associations are broken.

    @naemono
    naemono committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    a58c2da View commit details
    Browse the repository at this point in the history

  2. Allow error to be returned from doReconcile during defer. 

    Updating E2E tests to have similar design as Kibana, and ES E2E tests for generation bits.
    @naemono
    naemono committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    250fcb5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 3392-agent-observedGeneration

    @naemono
    naemono committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    a78d66d View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge branch 'main' of https://github.com/elastic/cloud-on-k8s into 3… 

    …392-agent-observedGeneration
    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    27027d0 View commit details
    Browse the repository at this point in the history

  2. ensure withmutatedfrom is used in e2e agent tests.

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    8b549f8 View commit details
    Browse the repository at this point in the history

  3. Ensure we're not returning nil results

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    28731f7 View commit details
    Browse the repository at this point in the history

  4. Fixing comparison issues from rebase/merge

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    ea5935e View commit details
    Browse the repository at this point in the history

  5. Add nolint for the naked return, which is required for the defer to f… 

    …unction properly.
    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    c10da1b View commit details
    Browse the repository at this point in the history

  6. Handle updating status properly when associations are broken.

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    3d9975d View commit details
    Browse the repository at this point in the history

  7. Debugging

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    bc4f919 View commit details
    Browse the repository at this point in the history

  8. Debugging, and moving the defer

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    ecad6df View commit details
    Browse the repository at this point in the history

  9. Go back to previous way of handling fetch association errors

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    4c8d2ec View commit details
    Browse the repository at this point in the history

  10. remove extraneous logging statement

    @naemono
    naemono committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    d7844d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Move status update to calling function. 

    Don't worry about status update when FetchWithASsociations fails.
Just return errors from updateStatus
    @naemono
    naemono committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    205b1cf View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Remove unused context

    @naemono
    naemono committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5177545 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Update the func's comments to be consistent

    @naemono
    naemono committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b850b4f View commit details
    Browse the repository at this point in the history

  2. remove unneeded return

    @naemono
    naemono committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    4e6f801 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Merge branch 'main' into 3392-agent-observedGeneration

    @naemono
    naemono committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    f782303 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. move common.LowestVersionFromPods closer to where pods are retrieved. 

    Update status logic to update health properly.
Add unit test for updating of health in agent status.
    @naemono
    naemono committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    0dea707 View commit details
    Browse the repository at this point in the history

  2. changes to return status instead of modifying a pointer.

    @naemono
    naemono committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    074933c View commit details
    Browse the repository at this point in the history

  3. rename variable

    @naemono
    naemono committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2894c06 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Updating how status is handled for consistency

    @naemono
    naemono committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    052fb3f View commit details
    Browse the repository at this point in the history