Use precondition when deleting secrets

[srteam2020]

Fix #5249

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?
• If you submit code, is your pull request against main? We recommend pull requests against main. We will backport them as needed.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[pebrc]

Hey thanks for the PR ! You would have to sign the CLA linked above in the checks section in order for use to merge the PR.

Also I think we would want to add the same predicate here:

cloud-on-k8s/pkg/controller/common/reconciler/secret.go

Line 213 in 9be005d

if err := c.Delete(context.Background(), &secret); err != nil && !apierrors.IsNotFound(err) {

And should maybe add a unit test to the existing test cases testing the new behaviour.

[pebrc]

Jenkins test this please

[srteam2020]

Hello @pebrc we have updated the PR but we didn't find a good way to write unit test to test the new behavior. Do you have any suggestion on that? What should we do to help merge this PR?

[pebrc]

Hey @srteam2020 if you could add the precondition also to the line I linked above #5273 (comment)

Once that's done I think I would be OK to merge this as is.

[srteam2020]

Sorry I missed that. Just updated the PR again.

[pebrc]

LGTM!

[pebrc]

Jenkins test this please