Change upgrade path validation for 8.0 to only allow 7.17 #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
reviewed
Jan 19, 2022
sebgl
approved these changes
Jan 19, 2022
| // this should not happen, since this is the already persisted version | ||
| errs = append(errs, field.Invalid(field.NewPath("spec").Child("version"), current.Spec.Version, parseStoredVersionErrMsg)) | ||
| currentVer, ferr := currentVersion(current) | ||
| if ferr != nil { |
There was a problem hiding this comment.
ferr for field.Error which is what the webhook API works with, err is used as a variable for a regular builtin error below
naemono
approved these changes
Jan 19, 2022
|
Jenkins test this please TestDelayingQueueInvariants is flaky sometimes unfortunately |
barkbay
reviewed
Jan 20, 2022
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Jan 20, 2022
This sets the minimal supported version for 8.0 to 7.17. It also changes the validation on version upgrade to take the .status.Version into account instead of the spec.Version (which it still uses as a fallback in case we do not have a valid .status.Version). The rationale behind that is that we want to make sure that users do update the version of the spec in quick succession without waiting for the rollout of the upgrade to complete thereby unwittingly circumventing the version restriction.
pebrc
added a commit
that referenced
this pull request
Jan 20, 2022
) This sets the minimal supported version for 8.0 to 7.17. It also changes the validation on version upgrade to take the .status.Version into account instead of the spec.Version (which it still uses as a fallback in case we do not have a valid .status.Version). The rationale behind that is that we want to make sure that users do update the version of the spec in quick succession without waiting for the rollout of the upgrade to complete thereby unwittingly circumventing the version restriction.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
This sets the minimal supported version for 8.0 to 7.17. It also changes the validation on version upgrade to take the .status.Version into account instead of the spec.Version (which it still uses as a fallback in case we do not have a valid .status.Version). The rationale behind that is that we want to make sure that users do update the version of the spec in quick succession without waiting for the rollout of the upgrade to complete thereby unwittingly circumventing the version restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5258
This sets the minimal supported version for 8.0 to 7.17. It also changes the validation on version upgrade to take the
.status.Versioninto account instead of thespec.Version(which it still uses as a fallback in case we do not have a valid.status.Version). The rationale behind that is that we want to make sure that users do update the version of thespecin quick succession without waiting for the rollout of the upgrade to complete thereby unwittingly circumventing the version restriction.