Ignore ClusterIPs, and IPFamilyPolicy in services, and timestamp in license during reconciliation #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e set server-side. Ignore timestamp in license configmap, as it will always change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing, it was found that services are updated every reconciliation cycle, along with the license. As for the license, the timestamp is always changing, which means it will always be updated. As for the services, ClusterIP, and IPFamilies are currently ignored, as they're set server-side, but ClusterIPs, and IPFamilyPolicy were not being ignored, but are also set server side. This updates the logic to also properly use or ignore these fields in services, and completely ignore timestamp when comparing license. The tests were also updated to ensure consistency.