Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the webhook server in e2e tests #2265

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Dec 13, 2019

Fix #2153

This PR sets the failure policy to Fail by default. You can change this behaviour by adding the following field ignore_webhook_failures to true in your e2e test context:

{
...
  "ignore_webhook_failures": true
}

@barkbay barkbay added :ci Things related to Continuous Integration, automation and releases >test Related to unit/integration/e2e tests labels Dec 13, 2019
Copy link
Contributor

@charith-elastic charith-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to add the --ignore-webhook-failures flag to the e2e-local target in the Makefile so that it continues to work after this change is merged.

@barkbay barkbay merged commit 1c6fb41 into elastic:master Dec 17, 2019
@barkbay barkbay deleted the use-webhook-e2e-tests branch December 17, 2019 07:00
mjmbischoff pushed a commit to mjmbischoff/cloud-on-k8s that referenced this pull request Jan 13, 2020
* Use the webhook server in e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci Things related to Continuous Integration, automation and releases >test Related to unit/integration/e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure e2e tests utilize webhook
2 participants