Skip to content

Commit

Permalink
[E2E][OpenShift] Do not strictly compare securityContext.Capabilities…
Browse files Browse the repository at this point in the history
….Drop
  • Loading branch information
barkbay committed Apr 24, 2023
1 parent 10351e2 commit d929102
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions test/e2e/test/elasticsearch/check_securitycontext.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,22 @@ func asserSecurityContext(t *testing.T, ver version.Version, securityContext *co
t.Helper()
require.NotNil(t, securityContext)
if strings.HasPrefix(image, "docker.elastic.co/elasticsearch/elasticsearch") && ver.LT(securitycontext.MinStackVersion) {
require.Nilf(t, securityContext.RunAsNonRoot, "RunAsNonRoot was expected to be nil")
require.Nil(t, securityContext.RunAsNonRoot, "RunAsNonRoot was expected to be nil")
} else {
require.Equal(t, ptr.Bool(true), securityContext.RunAsNonRoot, "RunAsNonRoot was expected to be true")
}
require.NotNil(t, securityContext.Privileged)
require.False(t, *securityContext.Privileged)
require.Equal(t, securityContext.Capabilities, &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
})

// OpenShift may add others Capabilities. We only check that ALL is included in "Drop".
require.NotNil(t, securityContext.Capabilities)
droppedCapabilities := (*securityContext.Capabilities).Drop
hasDropAllCapability := false
for _, capability := range droppedCapabilities {
if capability == "ALL" {
hasDropAllCapability = true
break
}
}
require.True(t, hasDropAllCapability, "ALL capability not found in securityContext.Capabilities.Drop")
}

0 comments on commit d929102

Please sign in to comment.