Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: reorganise code to improve code locality #36439

Merged
merged 6 commits into from
Aug 30, 2023
Merged

x-pack/filebeat/input/httpjson: reorganise code to improve code locality #36439

merged 6 commits into from
Aug 30, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 29, 2023 •
edited
Loading

Proposed commit message

Reorganise code and reduce complexity of registries in preparation for refactor.

Use conventional ordering: type, constructor, methods and caller before
callee in source order.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Recommend reviewing by commit rather as a single change.
  • Look the other way for linting complaints; they are not new and, if significant, will be addressed in the refactor.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat cleanup Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Aug 29, 2023
@efd6 efd6 self-assigned this Aug 29, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 29, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-29T02:33:20.381+0000

  • Duration: 76 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 3132
Skipped 176
Total 3308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review August 29, 2023 04:19
@efd6 efd6 requested a review from a team as a code owner August 29, 2023 04:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

marc-gr
marc-gr approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@efd6 efd6 merged commit eef9598 into elastic:main Aug 30, 2023
18 of 20 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/input/httpjson: reorganise code to improve code local…
618e797 
…ity (elastic#36439)

* chain.go => config_chain.go
* simplify encoding registry
* simplify transform registry
    This removes the registration code and makes the use of the registry
    effectively local rather than a mutated global. It also simplifies the
    structure of the registry type.
* improve code locality of chain helpers
* improve code locality of request
    Use conventional ordering: type, constructor, methods and caller before
    callee in source order.
* improve code locality of response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify cleanup enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @marc-gr