Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Update MISP module config file #15261

Merged
merged 4 commits into from
Jan 3, 2020
Merged

[Filebeat] Update MISP module config file #15261

merged 4 commits into from
Jan 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Current MISP module configuration file does not have var.api_key, var.json_objects_array and var.url in the example. This PR is to add them to make it easier to use.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner December 27, 2019 21:03
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 27, 2019
@kaiyan-sheng kaiyan-sheng added Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. review Team:Integrations Label for the Integrations team labels Dec 27, 2019
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(only a comment on URI/URL difference)

@kaiyan-sheng kaiyan-sheng merged commit 8560d82 into elastic:master Jan 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the misp_doc branch January 3, 2020 18:29
@kaiyan-sheng kaiyan-sheng added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 3, 2020
kaiyan-sheng added a commit that referenced this pull request Jan 7, 2020
* Update misp module config file

* Change URI to URL

(cherry picked from commit 8560d82)
kaiyan-sheng added a commit that referenced this pull request Jan 7, 2020
* Update misp module config file

* Change URI to URL

(cherry picked from commit 8560d82)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
)

* Update misp module config file

* Change URI to URL

(cherry picked from commit 84cef9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants