Fix mage package on generated beats #15140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mage package calls some targets by name (instead of by reference), and then these targets need to be defined in the main magefile. Add mage package to the test suite so we earlier detect these issues.
jsoriano
added
review
:Generator
jsoriano
added
needs_backport
radoondas
approved these changes
Dec 17, 2019
|
I am removing the tests by now because they were problematic in OSX builds where docker is not installed, and in local builds where I found it creating files owned by root (because of running the build on docker). |
|
Ok, ended up keeping the tests, but only on Linux builds, tests pass now. |
fearful-symmetry
approved these changes
Jan 6, 2020
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 8, 2020
Mage package calls some targets by name (instead of by reference), and then these targets need to be defined in the main magefile. Add mage package to the test suite so we earlier detect these issues. (cherry picked from commit 315837b)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 8, 2020
Mage package calls some targets by name (instead of by reference), and then these targets need to be defined in the main magefile. Add mage package to the test suite so we earlier detect these issues. (cherry picked from commit 315837b)
jsoriano
added a commit
that referenced
this pull request
Jan 9, 2020
jsoriano
added a commit
that referenced
this pull request
Jan 11, 2020
Mage package calls some targets by name (instead of by reference), and then these targets need to be defined in the main magefile. Add mage package to the test suite so we earlier detect these issues. (cherry picked from commit 315837b)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#15383) Mage package calls some targets by name (instead of by reference), and then these targets need to be defined in the main magefile. Add mage package to the test suite so we earlier detect these issues. (cherry picked from commit 3535491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mage package calls some targets by name (instead of by reference), and
then these targets need to be defined in the main magefile.
Add mage package to the test suite so we earlier detect these issues.
This is probably broken since #14162
Fix #15122