Stop using mage:import in custom beats 7.4 #14187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats. Revert part of elastic#13239 related to custom beats.
jsoriano
changed the title
jsoriano
force-pushed
the
remove-mage-import-custom-beats-7.4
branch
from
f7702c6
to
1d21cd3
Compare
jsoriano
added
:Generator
jsoriano
commented
Oct 22, 2019
| // Use RACE_DETECTOR=true to enable the race detector. | ||
| func GoTestIntegration(ctx context.Context) error { | ||
| return devtools.GoTest(ctx, devtools.DefaultGoTestIntegrationArgs()) | ||
| } |
There was a problem hiding this comment.
@fearful-symmetry so it seems that we had also a target for integration tests before, maybe I should include this target too in the changes for master/7.5. WDYT?
There was a problem hiding this comment.
I would think so, yah
radoondas
approved these changes
Oct 22, 2019
fearful-symmetry
approved these changes
Oct 25, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats. Revert part of elastic#13239 related to custom beats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mage:importdoesn't take into account vendorized dependencies, this is aproblen for custom beats, because by default they have libbeat as a
vendorized dependency. The solution would be to use go modules, but in
the meantime lets remove the use of
mage:importfrom the magefilesintended to be used by custom beats.
Revert part of #13239 related to custom beats, backports part of #14162.
Fixes #13998 for 7.4.