Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] API key documentation from libbeat #3227

Merged
merged 9 commits into from
Jan 30, 2020

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jan 22, 2020

DIFF/PREVIEW

This PR introduces some new libbeat documentation to APM Server:

While it would've been nicer to introduce these changes in a separate PRs, the API key, monitoring, and user docs are pretty tightly knit, and I was struggling to untangle things and get the docs to build in separate PRs.

To do: Requires a PR in beats to persist the changes. Added to elastic/beats#15835

@@ -18,9 +18,10 @@ by {beatname_uc}
create visualizations that access {beatname_uc} data

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's one thing you look at in this PR, make it this page. There's just so much going on here, it's tough to see if I caught everything that needs to be changed for APM Server. Here's a direct link to the preview for this page: http://apm-server_3227.docs-preview.app.elstc.co/guide/en/apm/server/master/feature-roles.html.

@bmorelli25 bmorelli25 marked this pull request as ready for review January 22, 2020 05:21
@bmorelli25 bmorelli25 changed the title [docs] Documentation from libbeat [docs] API key documentation from libbeat Jan 22, 2020
@bmorelli25 bmorelli25 merged commit 17e0f7a into elastic:master Jan 30, 2020
@bmorelli25 bmorelli25 deleted the docs-api-keys-es-output branch January 30, 2020 16:07
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 30, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document output.elasticsearch.api_key option
1 participant