-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure handling to ingest pipelines. #2896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unexpected infinite retries on pipeline failures due to internal callback handling, by defining failure handling on pipelines. closes elastic#2880
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
- Coverage 79.73% 79.26% -0.47%
==========================================
Files 89 83 -6
Lines 4830 4355 -475
==========================================
- Hits 3851 3452 -399
+ Misses 979 903 -76
|
graphaelli
approved these changes
Nov 13, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Nov 13, 2019
Avoid unexpected infinite retries on pipeline failures due to internal callback handling, by defining failure handling on pipelines. closes elastic#2880
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Nov 13, 2019
Avoid unexpected infinite retries on pipeline failures due to internal callback handling, by defining failure handling on pipelines. closes elastic#2880
simitt
added a commit
that referenced
this pull request
Nov 13, 2019
simitt
added a commit
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unexpected infinite retries on pipeline failures due to internal callback handling, by defining failure handling on pipelines.
For the
geoip
pipeline theclient.ip
field will be removed on failure. The field has anip
mapping in Elasticsearch. Therefore ingesting the document in ES would fail, even if the pipeline error is ignored in case of a malformed IP address. Dropping the malformed field, ensures the document can be indexed. Information inclient.ip
is always duplicated from some other field, therefore no original information is lost. While there is some pre-processing in place to avoid malformed IP addresses, this is the only case that comes to my mind that could make the pipeline fail.For the
user_agent
pipeline failures are simply ignored. Theuser_agent.original
field is indexed as a keyword and therefore less susceptible to ingestion failure on malformed user_agent information, and the failure handling only ensures edge cases are covered and unexpected ingestion issues avoided.closes #2880