fix: Temporary disable self trace apm config #13790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
approved these changes
Jul 30, 2024
axw
approved these changes
Jul 30, 2024
1pkg
changed the title
1pkg
force-pushed
the
temporary-disable-apm-tracer-config
branch
from
34fa867
to
b5daadb
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit a519c37)
2 tasks
simitt
reviewed
Jul 30, 2024
| @@ -33,5 +33,5 @@ https://github.com/elastic/apm-server/compare/v8.14.3\...v8.15.0[View commits] | |||
| - Upgraded bundled APM Java agent attacher CLI to version 1.50.0 {pull}13326[13326] | |||
| - Enable Kibana curated UIs to work with hostmetrics from OpenTelemetry's https://pkg.go.dev/go.opentelemetry.io/collector/receiver/hostmetricsreceiver[hostmetricsreceiver] {pull}13196[13196] | |||
| - Add require data stream to bulk index requests {pull}13398[13398] | |||
| - Support self-instrumentation when in managed mode by getting tracing configs via reloader {pull}13514[13514] {pull}13653[13653] {pull}13691[13691] | |||
| - Support self-instrumentation when in managed mode by getting tracing configs via reloader {pull}13514[13514] {pull}13653[13653] {pull}13691[13691] {pull}13790[13790] | |||
There was a problem hiding this comment.
My understanding is that EA doesn't support the instrumentation.enabled option, which is now set to false as default value. Which user impact does this have? Can users still enable self monitoring for (a) standalone EA (b) Fleet managed EA? We might need to adapt the changelog notes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This PR disables self-tracing monitoring in APM Server until the related issue in Elastic Agent is resolved.
Checklist
How to test these changes
Manual testing of self-tracing with Elastic Agent should always yield disabled instrumentation with this change.
Related issues