fix: span url hostname not ip

[astorm]

Fixes #2035

This PR add a getUrlFromRequestAndOptions function to the lib/instrumentation/http-shared.js module. The http-shared module also uses this new function in place of the old http-request-to-url module to set the url property on a span.

The getUrlFromRequestAndOptions function accepts a ClientRequest object and a generic options object and uses the information from those objects to return the same final URL that the ClientRequest will use. The options object is either

1. The options object passed to the request method

    http.request(options)
   

2. Or, in the case of http.request's second form

    http.request(url, options)
   

   the options object is merged with the URL information from url to create a new object.

In addition to the usual test suite, this was tested across all supported node versions with the following sludge-hammer of a bash script.

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #2039 updated

• Start Time: 2021-04-15T23:14:08.067+0000

• Duration: 17 min 17 sec

• Commit: a2c4777

Test stats 🧪

Test	Results
Failed	0
Passed	17136
Skipped	0
Total	17136

Trends 🧪

[astorm]

Tests failing in test/instrumentation/modules/http/outgoing.js for nodes 12.0 and 14.0, but passing in v14.14 or v12.22.1. Likely due to some subtly of localhost vs. 127.0.0.1. Will investigate.

[astorm]

Per discussions, we've removed the "pass everything through a URL object to sanitize" in order to simplify the function (and adjusted the final return value to use local variables instead of properties from that URL object). We've also added a parameter to the function that lets us pass in the moduleName to use as a fallback protocol. In tests we've moved the username:password to the auth section of the options and added some test assertions that check for the presence of either string in the final URL. We've also added a test to ensure that port 80, if supplied, is represented in the URL.

[trentm]

Drop these.