Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto.randomFillSync fails on Node.js 6.12.3 and below #701

Closed
watson opened this issue Dec 3, 2018 · 0 comments
Closed

crypto.randomFillSync fails on Node.js 6.12.3 and below #701

watson opened this issue Dec 3, 2018 · 0 comments
Assignees
@watson
Labels
bug

Comments

@watson
Copy link
Contributor

watson commented Dec 3, 2018 •
edited
Loading

Calls to crypto.randomFillSync was added in Node.js v6.13.0, so we have to add a polyfill if users use Node.js 6.12.3 or below.
@watson watson added the bug label Dec 3, 2018
@watson watson self-assigned this Dec 3, 2018
@watson watson mentioned this issue Dec 3, 2018
Closed
@watson watson changed the title crypto.randomFillSync fails on Node.js 6 crypto.randomFillSync fails on Node.js 6.12.3 and below Dec 3, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 3, 2018
@watson
fix: use randomFillSync polyfill on Node.js <6.13.0
66425d3 
Fixes elastic#701
This was referenced Dec 3, 2018
Merged
Merged
@Qard Qard closed this as completed in #702 Dec 4, 2018
Qard pushed a commit that referenced this issue Dec 4, 2018
@watson @Qard
fix: use randomFillSync polyfill on Node.js <6.13.0 (#702)
e8f5f0d 
Fixes #701
@zube zube bot reopened this Dec 4, 2018
@zube zube bot closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watson watson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@watson @alvarolobato