Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Define a proxy for plugin installation #60

Merged
merged 3 commits into from
Mar 21, 2016
Merged

Define a proxy for plugin installation #60

merged 3 commits into from
Mar 21, 2016

Conversation

barryib
Copy link
Contributor

@barryib barryib commented Jan 27, 2016

Address the issue ansible-elasticsearch #4 which add proxy for plugin installation and more generally es_proxy_host and es_proxy_port for global usage.

Right now, it’s only used for plugins installation. In the futur, it can be used (or defined) in the java_opts within the default file for instance (elasticsearch.j2)

Address the issue [ansible-elasticsearch
#4](#4) which
add proxy for plugin installation and more generally es_proxy_host and
es_proxy_port for global usage.

Right now, it’s only used for plugins installation. In the futur, it
can be used (or defined) in the java_opts within the default file for
instance (elasticsearch.j2)
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@electrical
Copy link
Contributor

jenkins, test it

@electrical
Copy link
Contributor

Thank you so much for the contribution! I'll let jenkins do its magic.
In the meantime could you sign the CLA?
Thanks!

@barryib
Copy link
Contributor Author

barryib commented Jan 27, 2016

@electrical I signed the CLA, but I don't know if it applied on this PR

@barryib
Copy link
Contributor Author

barryib commented Jan 27, 2016

Never mind. I was in the hurry :)

fix typo
@electrical
Copy link
Contributor

jenkins, test it

@electrical
Copy link
Contributor

failed some runs so trying again.

@barryib
Copy link
Contributor Author

barryib commented Jan 28, 2016

@electrical I think there are version incompatibility between net-ssh and ruby during tests. In all failed tests, I got this error: Gem::InstallError: net-ssh requires Ruby version >= 2.0.

@electrical
Copy link
Contributor

Yeah. will do some tests locally and fix the Gemfile.

@gingerwizard
Copy link

Hi @barryib picking this up as @electrical isn't focused on this anymore. Lets get it tested again and ill see if i can resolve.

@gingerwizard
Copy link

jenkins, test it

1 similar comment
@gingerwizard
Copy link

jenkins, test it

@gingerwizard
Copy link

@barryib If the tests pass ill merge

@gingerwizard
Copy link

jenkins, test it

@gingerwizard
Copy link

LGTM

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

gingerwizard pushed a commit that referenced this pull request Mar 21, 2016
@gingerwizard gingerwizard merged commit 3c5adf9 into elastic:master Mar 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants