Upgrade to Gradle 7.2 and add feature variants for Jakarta XML parsing support #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdennis
force-pushed
the
jakarta-variants
branch
from
7661298
to
8ee3b92
Compare
chrisdennis
force-pushed
the
jakarta-variants
branch
3 times, most recently
from
1020b20
to
3a74e9a
Compare
chrisdennis
force-pushed
the
jakarta-variants
branch
4 times, most recently
from
03f8c5c
to
87bfd8c
Compare
chrisdennis
force-pushed
the
jakarta-variants
branch
from
87bfd8c
to
d8caa39
Compare
|
What's the reason behind the transition from |
|
I think this is triggered by the move to the |
chrisdennis
force-pushed
the
jakarta-variants
branch
3 times, most recently
from
2062777
to
f0ea3b4
Compare
cljohnso
reviewed
Dec 6, 2021
...xml/src/main/java/org/ehcache/xml/provider/SimpleCoreServiceCreationConfigurationParser.java
Outdated
Show resolved
Hide resolved
ehcache-xml/src/jakarta/java/org/ehcache/xml/multi/XmlMultiConfiguration.java
Outdated
Show resolved
Hide resolved
chrisdennis
force-pushed
the
jakarta-variants
branch
from
f0ea3b4
to
9406763
Compare
cljohnso
approved these changes
Dec 7, 2021
* org.ehcache.modules:ehcache-xml * org.ehcache.modules:ehcache-107 * org.ehcache:ehcache
chrisdennis
force-pushed
the
jakarta-variants
branch
from
9406763
to
2e03984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Ehcache build to use Gradle 7.2. At the same time it adds support for lightweight (same artifact) and heavyweight (split sources and artifacts) feature variants to support the optional use of Jakarta namespaced libraries for XML parsing.
Along with the Gradle 7.2 build changes come some associated (mandated?) dependency scoping changes:
org.ehcache.modules:ehcache-107javax.cache:cache-api:provided→compileorg.ehcache.modules.ehcache-xmljavax.xml.bind:jaxb-api:<absent>→compileorg.glassfish.jaxb:jaxb-runtime:provided→runtimejakarta.xml.bind:jakarta.xml.bind-api:<absent>→compile(optional)org.ehcache:ehcacheorg.slf4j:slf4j-api:compile→runtimejavax.cache:cache-api:provided→compileorg.glassfish.jaxb:jaxb-runtime:provided→runtimeorg.ehcache:ehcache-clusteredorg.slf4j:slf4j-api:compile→runtimeorg.ehcache:ehcache:compile→runtime