Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release the first stable version 🥚 👏👏👏 #605

Merged
merged 2 commits into from
Mar 21, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Mar 21, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Closes #5

@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @atian25, @fengmk2 and @dead-horse to be potential reviewers.

@jtyjty99999
Copy link
Member

👏👏👏

Copy link
Member

@atian25 atian25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@codecov
Copy link

codecov bot commented Mar 21, 2017

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #605   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         633    633           
=====================================
  Hits          633    633

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ad38d...385c568. Read the comment docs.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@fengmk2
Copy link
Member

fengmk2 commented Mar 21, 2017

@popomore Please merge and release!

@fengmk2 fengmk2 added this to the 1.0.0 milestone Mar 21, 2017
@popomore
Copy link
Member Author

覆盖率降低和 egg-bin 有关系?

@atian25
Copy link
Member

atian25 commented Mar 21, 2017

@popomore 换回去 2.x 跑跑看?

@popomore
Copy link
Member Author

istanbul bin is not found 没找到,本地是可以跑过的

@atian25
Copy link
Member

atian25 commented Mar 21, 2017

有可能是这个原因,

https://github.com/eggjs/egg-bin/blob/master/lib/cmd/cov.js#L59

上面复制了,下面才赋值,我发个 PR 修复下

@atian25
Copy link
Member

atian25 commented Mar 21, 2017

win 又卡在了 -.-

@popomore
Copy link
Member Author

覆盖率好像解决了

@popomore popomore merged commit 8a64ceb into master Mar 21, 2017
@popomore popomore deleted the release-proposal-1.0.0 branch March 21, 2017 08:38
@popomore
Copy link
Member Author

  • egg@1.0.0

@atian25
Copy link
Member

atian25 commented Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0 Milestone
5 participants