Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git information to show stable versions in banner #516

Closed
wants to merge 1 commit into from

Conversation

jpellegrini
Copy link
Contributor

See issue #515

  • When compiling from a git checkout, a stable version will be detected and included in git-info.h
  • In runtime.stk there is a new procedure, stklos-stable?, that will tell if this STklos binary was compiled from a stable release
  • In repl.stk, we use this to make the banner more informative: After creating a "10.1" tag for the current commit and reconfiguring and compiling STklos, we have:
  \    STklos version 10.1
   \   Copyright (C) 1999-2023 Erick Gallesio <eg@stklos.net>
  / \  [Linux-6.1.0-5-amd64-x86_64/pthreads/readline/utf8]
 /   \ Type ',h' for help

If we delete the tag, reconfigure and compile again,

  \    STklos version post-1.70 (git commit fefabbde)
   \   Copyright (C) 1999-2023 Erick Gallesio <eg@stklos.net>
  / \  [Linux-6.1.0-5-amd64-x86_64/pthreads/readline/utf8]
 /   \ Type ',h' for help

@jpellegrini
Copy link
Contributor Author

The stklos-stable? procedure can be cleaned up a bit - but the idea is there...

* When compiling from a git checkout, a stable version will
  be detected and included in `git-info.h`
* In `runtime.stk` there is a new procedure, `stklos-stable?`,
  that will tell if this STklos binary was compiled from a stable
  release
* In `repl.stk`, we use this to make the banner more informative:
  After creating a "10.1" tag for the current commit and reconfiguring
  and compiling STklos, we have:

```
  \    STklos version 10.1
   \   Copyright (C) 1999-2023 Erick Gallesio <eg@stklos.net>
  / \  [Linux-6.1.0-5-amd64-x86_64/pthreads/readline/utf8]
 /   \ Type ',h' for help
```

If we delete the tag, reconfigure and compile again,

```
  \    STklos version post-1.70 (git commit fefabbde)
   \   Copyright (C) 1999-2023 Erick Gallesio <eg@stklos.net>
  / \  [Linux-6.1.0-5-amd64-x86_64/pthreads/readline/utf8]
 /   \ Type ',h' for help
```
@jpellegrini
Copy link
Contributor Author

@egallesio this one is not necessary anymore - right?

@egallesio
Copy link
Owner

@egallesio this one is not necessary anymore - right?

You're right. Closing it.

@egallesio egallesio closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants