fix crashing sources && better getContent

eea · Jan 11, 2023 · a202967 · a202967
1 parent ed1873c
commit a202967
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/src/Blocks/EmbedEEATableauBlock/Edit.jsx b/src/Blocks/EmbedEEATableauBlock/Edit.jsx
@@ -22,7 +22,7 @@ const Edit = (props) => {
 
   React.useEffect(() => {
     props.getContent(data.vis_url, null, id);
-    //    eslint-disable-next-line react-hooks/exhaustive-deps
+    //  eslint-disable-next-line react-hooks/exhaustive-deps
   }, [data.vis_url]);
 
   return (

diff --git a/src/Blocks/EmbedEEATableauBlock/View.jsx b/src/Blocks/EmbedEEATableauBlock/View.jsx
@@ -13,7 +13,7 @@ const View = (props) => {
 
   React.useEffect(() => {
     if (vis_url) {
-      props.getContent(vis_url, null);
+      props.getContent(vis_url, null, props.id);
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [vis_url]);

diff --git a/src/Sources/Sources.jsx b/src/Sources/Sources.jsx
@@ -27,16 +27,17 @@ const SourcesWidget = ({ data }) => {
       </a>
       {expand && (
         <ul>
-          {data.map((param, i) => (
-            <li key={i} className="embed-source-param">
-              <UniversalLink
-                className="embed-sources-param-title"
-                href={param.source_link}
-              >
-                {param.source}
-              </UniversalLink>
-            </li>
-          ))}
+          {data &&
+            data.map((param, i) => (
+              <li key={i} className="embed-source-param">
+                <UniversalLink
+                  className="embed-sources-param-title"
+                  href={param.source_link}
+                >
+                  {param.source}
+                </UniversalLink>
+              </li>
+            ))}
         </ul>
       )}
     </div>