Add a comment about side-effects

eea · Oct 8, 2021 · be9ef0c · be9ef0c
1 parent a22eead
commit be9ef0c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/SearchBlock/SearchBlockView.jsx b/src/SearchBlock/SearchBlockView.jsx
@@ -1,5 +1,6 @@
 import React from 'react';
 import config from '@plone/volto/registry';
+// import { cloneDeep } from 'lodash';
 import { SearchApp } from '@eeacms/search';
 import { SearchBlockSchema } from './schema';
 
@@ -18,6 +19,10 @@ import './styles.less';
  */
 const applyBlockSettings = (config, appName, data, schema) => {
   // apply mutations inline to the config
+
+  // config = cloneDeep(config);
+  // TODO: this has the side-effect that it mutates the global config
+  // Viewing this block will also "fix" the global config for the middleware
   const settings = config.searchui[appName];
   Object.keys(data).forEach((fieldName) => {
     const field = schema.properties[fieldName];