hide facets if has no values to show

eea · Nov 15, 2023 · 0a1740a · 0a1740a
1 parent 96dac21
commit 0a1740a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/searchlib/components/Facets/Wrappers/AccordionFacetWrapper.jsx b/searchlib/components/Facets/Wrappers/AccordionFacetWrapper.jsx
@@ -9,7 +9,7 @@ import Facet from '../Facet';
 const AccordionFacetWrapper = (props) => {
   const { collapsable = true, field, label } = props;
   const searchContext = useSearchContext();
-  const { filters } = searchContext;
+  const { facets, filters } = searchContext;
 
   const hasFilter = !!filters.find((filter) => field === filter.field);
   const [openFacets] = useAtom(openFacetsAtom);
@@ -42,7 +42,7 @@ const AccordionFacetWrapper = (props) => {
 
   let isOpened = openFacets[field]?.opened || false;
   const [counter, setCounter] = React.useState(0);
-
+  if (facets[field] === undefined) return null;
   return collapsable ? (
     <Accordion>
       <Accordion.Title

diff --git a/searchlib/components/Facets/Wrappers/DropdownFacetWrapper.jsx b/searchlib/components/Facets/Wrappers/DropdownFacetWrapper.jsx
@@ -36,7 +36,7 @@ const DropdownFacetWrapper = (props) => {
     searchContext: facetSearchContext,
     applySearch,
   } = useProxiedSearchContext(rawSearchContext);
-  const { filters } = facetSearchContext;
+  const { facets, filters } = facetSearchContext;
 
   const { appConfig } = useAppConfig();
   const facet = appConfig.facets?.find((f) => f.field === field);
@@ -64,6 +64,7 @@ const DropdownFacetWrapper = (props) => {
 
   const { width } = useWindowDimensions();
   const isSmallScreen = width < SMALL_SCREEN_SIZE;
+  if (facets[field] === undefined) return null;
 
   return (
     <>