Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat+fix): Use BlocksForm instead of SlateEditor to render more slates block #44

Merged
merged 22 commits into from
Apr 3, 2024

Conversation

dobri1408
Copy link
Contributor

@dobri1408 dobri1408 commented Mar 27, 2024

Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback in ticket

dobri1408 and others added 12 commits April 1, 2024 11:18
…Hero block view component

- We needed it only in the edit, and we can use an edit wrapper to add the onClick to it with role='presentational' so that we avoid eslint-disable-next-line comments
…f inner div wrapper

- it was used for quoted-wrapper which was moved to the Hero.Text div
- jenkins testing gave the error:
  Module ts-jest in the transform option was not found.
@ichim-david ichim-david merged commit 57953c5 into develop Apr 3, 2024
6 checks passed
@ichim-david ichim-david deleted the multiline-bug branch April 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants