refactor(breadcrumbs): update less variables

eea · Feb 14, 2022 · 640817e · 640817e
1 parent eb257f8
commit 640817e
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 54 deletions.
diff --git a/theme/themes/eea/collections/breadcrumb.overrides b/theme/themes/eea/collections/breadcrumb.overrides
@@ -3,81 +3,55 @@
 *******************************/
 
 div.eea-breadcrumb .ui.breadcrumb {
-  display: inline-flex;
-  flex-wrap: wrap;
-  align-items: end;
-  padding-right: 0;
-  padding-left: 0;
-
   .section {
-    padding: 0 5px;
-  }
+    padding: @mobileBreadcrumbPadding;
+    font-size: @mobileBreadcrumbFontSize;
+    font-weight: @activeFontWeight;
 
-  a.section {
-    color: @primaryColor;
-    font-size: 7px;
+    /* Max breadcrumb length to be decided */
+    //max-width: 150px;
+    //white-space: nowrap;
+    //overflow: hidden;
+    //text-overflow: ellipsis;
 
     img {
-      width: 7.5px;
+      width: @mobileBreadcrumbIconSize;
+      margin-bottom: -1px; //To align as the design
     }
   }
 
-  .section.active {
-    font-size: 7px;
-    font-weight: @activeFontWeight;
-  }
-
-  .icon.divider {
-    color: @deepBlue;
-  }
-
-  .home.icon {
-    margin-right: 0;
-  }
-
-  i.icon {
-    font-size: 7px;
+  i.icon.divider {
+    font-size: @mobileBreadcrumbFontSize;
   }
 
   a:first-child {
-    padding: 0 5px 0 0;
+    padding: 0 0.469rem 0 0;
   }
 
-  @media only screen and (min-width: @tabletBreakpoint) {
-    padding-right: 0;
-    padding-left: 0;
-  }
 }
-@media only screen and (min-width: @mobileBreakpoint + 1) {
+@media only screen and (min-width: @tabletBreakpoint) {
   div.eea-breadcrumb .ui.breadcrumb {
-    a.section {
-      color: @primaryColor;
-      font-size: @linkSize;
-
-      img {
-        width: 12px;
-      }
-    }
 
-    .section.active {
-      font-size: @linkSize;
+    .section {
+      padding: @tabletBreadcrumbPadding;
+      font-size: @tabletBreadcrumbFontSize;
       font-weight: @activeFontWeight;
-    }
 
-    i.icon {
-      font-size: 12px;
+      img {
+        width: @tabletBreadcrumbIconSize;
+      }
     }
 
-    .section {
-      padding: 0 7.5px;
+    i.icon.divider {
+      font-size: @tabletBreadcrumbIconSize;
     }
   }
 }
 
-@media only screen and (min-width: @tabletBreakpoint + 1) {
+@media only screen and (min-width: @computerBreakpoint) {
   div.eea-breadcrumb .ui.breadcrumb {
     .section {
-      padding: 0 10px;
+      padding: @computerBreadcrumbPadding;
     }
   }
 }
diff --git a/theme/themes/eea/collections/breadcrumb.variables b/theme/themes/eea/collections/breadcrumb.variables
@@ -6,15 +6,25 @@
      Breadcrumb
 --------------------*/
 
-@linkSize: 12px;
-
 @verticalMargin: 0em;
 @display: inline-block;
 @verticalAlign: middle;
 
-@dividerSpacing: @10px;
+@mobileBreadcrumbFontSize: @7px;
+@tabletBreadcrumbFontSize: @12px;
+
+@mobileBreadcrumbPadding: 0;
+@tabletBreadcrumbPadding: 0 @7px;
+@computerBreadcrumbPadding: 0 @10px;
+
+/* Icon */
+@mobileBreadcrumbIconSize: 0.469rem;
+@tabletBreadcrumbIconSize: @12px;
+
+/* Divider */
+@dividerSpacing: @5px;
 @dividerOpacity: 0.7;
-@dividerColor: @teal;
+@dividerColor: @deepBlue;
 
 @dividerSize: @relativeSmall;
 @dividerVerticalAlign: baseline;