Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for #255 #256

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Update README for #255 #256

merged 1 commit into from
Feb 24, 2020

Conversation

VincentTam
Copy link
Contributor

@VincentTam VincentTam commented Jan 6, 2019 •
edited

  • Show in the README that Staticman works with GitLab
  • Specify the correct format of RSA key

The term "SSH key" is misleading and ambiguous because Staticman doesn't use SSH and GitHub and GitLab support several encryption algorithms for the SSH key. That leads to errors in #244.

@VincentTam VincentTam mentioned this pull request May 18, 2019
Closed
This was referenced Jul 2, 2019
Closed
Closed
@VincentTam VincentTam mentioned this pull request Aug 2, 2019
Closed
@alexwaibel alexwaibel self-assigned this Dec 7, 2019
alexwaibel
alexwaibel approved these changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@alexwaibel alexwaibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The correction about the key type is especially helpful and has been the source of much confusion for users. Thank you for this contribution.

@alexwaibel alexwaibel merged commit 25c651e into eduardoboucas:dev Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwaibel alexwaibel alexwaibel approved these changes

Assignees

@alexwaibel alexwaibel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VincentTam @alexwaibel