Allow auth identity provider selection using provider query parameter
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `provider` query parameter to allow users to select the specific authentication provider they wish to use when authenticating through Staticman. This is useful in situations where the site repository is hosted on a different provider to the authentication provider. For example, if the site is hosted on GitHub, but the commenter wishes to sign in through GitLab. Consequently, this is a prerequisite to adding additional authentication providers in the future.
ntsim
changed the title
provider query parameterprovider query parameter
Merged
|
I've incorporated this PR at f9675f9 to my testing API instance for others to test. I've not tested it though. |
This was referenced Nov 23, 2018
This was referenced Jun 25, 2019
This was referenced Jul 3, 2019
caiopavanelli
pushed a commit
to caiopavanelli/staticman
that referenced
this pull request
Aug 17, 2020
[Bug fix] Corrected Japanese Staticman UI string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of pull request #219 and is a result of it's consequent discussion.
Currently the
/authendpoint will only allow authentication with the same service provider that the site repository is hosted on. For example, a commenter can only authenticate with GitHub if the repository is on GitHub, similarly with GitLab.This pull request adds the
providerquery parameter to the/authendpoint allowing the user to specify whatever identity provider they wish to use (and that we offer an integration with). This is important as it opens up multiple authentication options for commenters and allow us to extend the number of available providers in the future. An example usage might look like: