Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove SystemManagementClient #795

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat!: remove SystemManagementClient #795

merged 1 commit into from
Feb 14, 2023

Conversation

chr1shung
Copy link

BREAKING CHANGE: remove SystemManagementClient

closes #790

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

BREAKING CHANGE: remove SystemManagementClient

closes #790

Signed-off-by: Chris Hung <chris@iotechsys.com>
@codecov-commenter
Copy link

Codecov Report

Merging #795 (4228851) into main (77bba85) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   64.48%   64.42%   -0.06%     
==========================================
  Files          81       80       -1     
  Lines        3114     3092      -22     
==========================================
- Hits         2008     1992      -16     
+ Misses        914      911       -3     
+ Partials      192      189       -3     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 1b561ae into edgexfoundry:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove System Client
3 participants